New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite infra DSL secrets page CHEF-8415 #4209

Merged

IanMadd merged 4 commits into main from im/secrets

Nov 28, 2023

Contributor

IanMadd commented Nov 20, 2023 •

edited

Loading

Description

Reorganize the text a bit
Add text about default secret manager and default config

Definition of Done

Issues Resolved

https://chefio.atlassian.net/browse/CHEF-8415

Related PRs

chef/chef#12140

Check List

Spell Check
Local build
Examine the local build
All tests pass

IanMadd requested a review from a team as a code owner

November 20, 2023 20:18

netlify bot commented Nov 20, 2023 •

edited

Loading

✅ Deploy Preview for chef-web-docs ready!

Name	Link
🔨 Latest commit	`d3a3e3e`
🔍 Latest deploy log	https://app.netlify.com/sites/chef-web-docs/deploys/6565f3b3b1bc790008465c83
😎 Deploy Preview	https://deploy-preview-4209--chef-web-docs.netlify.app/release_notes_server
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions bot added the Documentation label


          rewrite infra DSL secrets page

bcfb104

Signed-off-by: Ian Maddaus <[email protected]>

IanMadd force-pushed the im/secrets branch 2 times, most recently from 4e6464b to 93c5049 Compare

November 20, 2023 20:47


          linting

6a89de3

Signed-off-by: Ian Maddaus <[email protected]>

IanMadd force-pushed the im/secrets branch from 93c5049 to 6a89de3 Compare

November 20, 2023 20:54

IanMadd requested a review from johnmccrae

November 20, 2023 21:00


          typo

b977e1a

Signed-off-by: Ian Maddaus <[email protected]>

johnmccrae approved these changes

View reviewed changes


          Merge branch 'main' into im/secrets

d3a3e3e

sonarqubecloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

IanMadd merged commit ecd7ccd into main

13 of 14 checks passed

IanMadd deleted the im/secrets branch

November 28, 2023 14:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels